menu bar in linux

[kerolloz]

Description

Version

• GitHub Desktop: GitHubDesktop-linux-1.5.1-linux2.deb

• Operating system: Ubuntu 18.10

Steps to Reproduce

Expected Behavior

menu bar doesn't seem to be working properly

Actual Behavior

menu bar should appear with the names for each menu

Additional Information

Logs

I have no idea how to access logs in linux!

[vitalkanev]

I believe this is an issue with the Yaru theme. See ubuntu/yaru#969

[kerolloz]

@vitalkanev
Okay this solves the issue when I change the theme to Yaru Dark. but I really like the light one.

[shiftkey]

@kerolloz thanks for the feedback. I actually think switching to use the in-app menu that Windows supports here is the best thing to do here.

Here's an example of it in action:

With this change we should make it a chromeless window, but maybe that's not the best idea.

[kerolloz]

@shiftkey I'm sorry. I didn't get what Windows has to do with my Ubuntu.

we should make it a chromeless window

How would that help me fix my problem?

[shiftkey]

@kerolloz it would address the problem by not using the OS default menu (it would also blend in nicer on OSes with light themes)

[kerolloz]

@shiftkey Thanks, I got it.
Does that have to do with Electron(or its version)?
cause I got the same issue with Atom!
but surprisingly Slack is working properly 😃.

[shiftkey]

Does that have to do with Electron(or its version)?

It's related to Electron and it trying to show a default menu that fits with the OS theme. electron/electron#15878 seems to be the fix but I think it's only just made it into 4.0.1 - maybe it'll be backported to earlier versions in time.

but surprisingly Slack is working properly 😃

I'm not sure what Slack is doing here - I haven't tested it out on Linux.