Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Electron 19.0.0 as it is broken on Buster/Bionic and older GLIBC distros #779

Closed
theofficialgman opened this issue Oct 22, 2022 · 3 comments

Comments

@theofficialgman
Copy link

theofficialgman commented Oct 22, 2022

The problem

"electron": "19.0.0",

desktop/yarn.lock

Lines 3887 to 3894 in c506ab2

electron@19.0.0:
version "19.0.0"
resolved "https://registry.yarnpkg.com/electron/-/electron-19.0.0.tgz#f6b742b708ec118676ba3b38d0f3712d8f0311cf"
integrity sha512-VXwqLQxuIUr0SI8vOYDj5OLPwtKa/trn5DVKd/BFGT/U/IerfVoSZuydGLOjSL5yJlckfmKQpiq+8PW4gI8hXA==
dependencies:
"@electron/get" "^1.14.1"
"@types/node" "^16.11.26"
extract-zip "^1.0.3"

refer to my blacklist of bad electron versions Botspot/pi-apps#1930

you need to upgrade to 19.0.5+ for this to be fixed.

In general the original release of electron for a specific version is always terrible, never use it until it is many releases in. I realize this version bump from 17.X to 19.0.0 came from upstream but it is just something that you need to check especially on linux.

Release version

3.1.1-linux1

Operating system

Bionic/Buster

Steps to reproduce the behavior

No response

Log files

No response

Screenshots

No response

Additional context

No response

@shiftkey
Copy link
Owner

you need to upgrade to 19.0.5+ for this to be fixed.

While I wait to queue this up, 3.0.7 is the latest release on Electron 17 for folks who encounter this issue.

@theofficialgman
Copy link
Author

theofficialgman commented Oct 26, 2022

@shiftkey I should have been more specific.
19.0.0-19.0.4 were only broken on arm64 (as Google disabled the glibc reversion script on arm64 only due to issues with ChromeOS arm64).
You aren't in need of a release since you don't build from that but regardless it would be good to change in the repo.

@shiftkey
Copy link
Owner

Closing this out as 3.1.5-linux2 has the last v19 release (development is currently on v22 so the next release will jump to that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants