perf: bundle wasm binary in chunk for shiki/wasm and @shikijs/core/wasm-inlined
#624
+38
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
- Coverage 96.17% 96.14% -0.03%
==========================================
Files 70 71 +1
Lines 5698 5709 +11
Branches 751 753 +2
==========================================
+ Hits 5480 5489 +9
- Misses 212 214 +2
Partials 6 6 ☔ View full report in Codecov by Sentry. |
diegohaz
referenced
this pull request
in ariakit/ariakit
Mar 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [shiki](https://togithub.com/shikijs/shiki) ([source](https://togithub.com/shikijs/shiki/tree/HEAD/packages/shiki)) | [`1.1.7` -> `1.2.0`](https://renovatebot.com/diffs/npm/shiki/1.1.7/1.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>shikijs/shiki (shiki)</summary> ### [`v1.2.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.2.0) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.1.7...v1.2.0) ##### 🚀 Features - Upgrade deps, new lang `Gleam`, new theme `Houston` - by [@​antfu](https://togithub.com/antfu) [<samp>(163d8)</samp>](https://togithub.com/shikijs/shiki/commit/163d83b6) ##### 🏎 Performance - Bundle wasm binary in chunk for `shiki/wasm` and `@shikijs/core/wasm-inlined` - by [@​antfu](https://togithub.com/antfu) in [https://github.com/shikijs/shiki/issues/624](https://togithub.com/shikijs/shiki/issues/624) [<samp>(56d1a)</samp>](https://togithub.com/shikijs/shiki/commit/56d1a486) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.1.7...v1.2.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: pi0/nuxt-shiki#18
Performance improvements for reduce the request waterflow on requesting wasm binary.
Before this PR,
@shikijs/core/wasm-inlinedhad an internal async chunk for lazy loading, but that take away the ability for users to have fine-grain control of when the chunk been loaded.This PR makes the importing
shiki/wasmand@shikijs/core/wasm-inlineddirectly import the binary within that chunk. So you can choice when and how to load the module.More user-facing
import { getWasmInlined } from 'shiki'renames unchanged