From 6f38d295b941286cf622939c2268b3a910d58bdf Mon Sep 17 00:00:00 2001 From: Michal Szestowicki Date: Mon, 22 Mar 2021 19:34:08 +0100 Subject: [PATCH 1/2] Removed duplicated code in test and documentation 'releaseName' property is set in integration test twice. To keep code clear the duplication is removed. --- README.md | 5 +---- .../shipkit/gh/release/GithubReleasePluginIntegTest.groovy | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 65aa22b..fbb8b9a 100644 --- a/README.md +++ b/README.md @@ -280,11 +280,8 @@ Complete task configuration //The file with changelog (release notes), *no default* changelog = file("changelog.md") - //The name of the release name, default as below + //The name of the release, default as below releaseName = "v" + project.version - - //The release tag, default as below - releaseName = "v" + project.version //Github token used for posting to Github API, *no default* githubToken = System.getenv("GITHUB_TOKEN") // using env var to avoid checked-in secrets diff --git a/src/integTest/groovy/org/shipkit/gh/release/GithubReleasePluginIntegTest.groovy b/src/integTest/groovy/org/shipkit/gh/release/GithubReleasePluginIntegTest.groovy index ab7671c..637f195 100644 --- a/src/integTest/groovy/org/shipkit/gh/release/GithubReleasePluginIntegTest.groovy +++ b/src/integTest/groovy/org/shipkit/gh/release/GithubReleasePluginIntegTest.groovy @@ -50,10 +50,7 @@ class GithubReleasePluginIntegTest extends BaseSpecification { //The file with changelog (release notes), *no default* changelog = file("changelog.md") - //The name of the release name, default as below - releaseName = "v" + project.version - - //The release tag, default as below + //The name of the release, default as below releaseName = "v" + project.version //SHA of the revision from which release is created; *no default* From f4dd9f229370f1374086583074bc215ad873c92d Mon Sep 17 00:00:00 2001 From: Michal Szestowicki Date: Mon, 22 Mar 2021 19:43:56 +0100 Subject: [PATCH 2/2] Fixed link in documentation Corrected path in the link to GithubReleasePluginIntegTest --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fbb8b9a..53605a1 100644 --- a/README.md +++ b/README.md @@ -263,7 +263,7 @@ Basic task configuration ``` Complete task configuration -(source: [GithubReleasePluginIntegTest](https://github.com/shipkit/shipkit-changelog/blob/master/src/integTest/groovy/org/shipkit/github/release/GithubReleasePluginIntegTest.groovy)) +(source: [GithubReleasePluginIntegTest](https://github.com/shipkit/shipkit-changelog/blob/master/src/integTest/groovy/org/shipkit/gh/release/GithubReleasePluginIntegTest.groovy)) ```groovy plugins {