Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM does not allow ads to be displayed on installation #64

Closed
kpfefferle opened this issue Sep 21, 2020 · 4 comments · Fixed by #65
Closed

NPM does not allow ads to be displayed on installation #64

kpfefferle opened this issue Sep 21, 2020 · 4 comments · Fixed by #65

Comments

@kpfefferle
Copy link
Contributor

When running yarn install in a project using this polyfill, the console outputs the following advertisement:

ad

NPM's policies prohibit the display of advertisements by packages during installation. From NPM's Open Source Policies:

These kinds of commercial content generally aren't acceptable:
...
2. Packages that display ads at runtime, on installation, or at other stages of the software development lifecycle, such as via npm scripts.

NPM's CTO made some additional comments regarding this issue about a year ago when this policy was put into place: https://www.zdnet.com/article/npm-bans-terminal-ads/

It looks like the offending code was added 2 months ago by #60, I assume unaware that this behavior had already been banned by NPM?

@RobbieTheWagner
Copy link
Member

@kpfefferle I was unaware this was banned. There seem to be many projects logging whatever they want, like core-js asking for a job for the maintainer etc. Are you positive this isn't okay? We maintain the package, and I don't think mentioning we can help if you want is that bad.

@kpfefferle
Copy link
Contributor Author

@rwwagner90 I assumed that you were not aware of the policy since the ad was just recently added, but it's definitely not okay to be doing this. We've had multiple developers at our company specifically complain about your ad, leaving them with a bad impression of Ship Shape - which is why I'm trying to bring it to your attention and get it fixed rather than file a complaint with NPM or some other escalating nonsense.

As for core-js, you can see the backlash against that project's behavior in zloirock/core-js#635. The core-js package has even seen forks specifically geared around removing the ad.

My assumption is you're not seeing a wider backlash (yet) since the number of projects that are both on an older version of Ember and also using forward-facing polyfills such as this one are few. The Ember community has long had a reputation for its spirit of community and collaboration, so I'm hoping that you will do the right thing and remove this advertisement without the need for this project to be forked and/or reported to NPM.

@RobbieTheWagner
Copy link
Member

@kpfefferle To me, it seems like NPM is the bad guy here. People providing countless hours of their free time for open source, free software, who just want to put a small message in the console advertising to help them sustain their efforts should not be banned for doing so.

I'll merge your PR and comply, but I do not understand why you or your colleagues are upset by the message. If you were interested in help updating, you might be glad to see the message. There are always two sides to see and empathize with.

@kpfefferle
Copy link
Contributor Author

@rwwagner90 Thank you in advance for merging the PR to remove the ad.

NPM's policy was written in direct response to widespread and vocal backlash throughout the community against the particular practice of advertising in the console. Our company in particular has engineers already dedicated to upgrading our version of Ember, and having an advertisement appear every time any developer in the company runs yarn install in our Ember project feels spammy really fast and thus reflects negatively on Ship Shape.

Most of the Ember-focused devs in our company have spent considerable time working as consultants and involved in open source, so we certainly sympathize with the challenge of finding support to sustain those efforts. Please know that we wish you and Ship Shape well, and we fully support the other solicitation efforts you've made via this project's README and "Sponsor" button. A huge part of my motivation in bringing this to you directly has been the hope of addressing the issue without doing further damage to Ship Shape's reputation. I assure you that I have no interest in dragging you, Ship Shape, or anyone else in the Ember community through the mud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants