Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output is broken for IE11 #55

Open
G-Rath opened this issue May 18, 2019 · 0 comments
Open

Output is broken for IE11 #55

G-Rath opened this issue May 18, 2019 · 0 comments

Comments

@G-Rath
Copy link
Contributor

G-Rath commented May 18, 2019

For some reason, the CDN plugin is just not working in IE11 - every time it replaces a package that is used, an error of some kind happens.

The pages load fine in other browsers.

I've tried this all the way back to v2.

Heres an example repo.

@Van-Nguyen could you do me a huge favor and look into this for me ASAP?
I've tried comparing the the output from webpack between cdn'd and non-cdn'd builds, but I don't know nearly enough about how this plugin & webpack work to be able to start figuring out whats going wrong.

To me it seems that maybe things are not being imported in time? I can confirm that in IE the libraries do make it there, but it could be that IE doesn't respect the order script tags are loaded when executing?

ss+(2019-05-18+at+10 34 30)

What's weird is that looking into it axios does seem to work properly, but it doesn't in my other project.
Meanwhile, prop-types give Failed prop type errors that don't appear if I don't cdn the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant