Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phive doesn't work on PHP7.1 #366

Closed
3 of 5 tasks
dbrekelmans opened this issue Dec 13, 2020 · 1 comment
Closed
3 of 5 tasks

Phive doesn't work on PHP7.1 #366

dbrekelmans opened this issue Dec 13, 2020 · 1 comment
Assignees
Labels
workflow-edit Issue can be fixed by editing the GitHub Action workflow

Comments

@dbrekelmans
Copy link

Describe the bug
With php-version: 7.1 and tools: phive, this action installs a version of phive that is not compatible with php7.1. Phive's github releases mention: Please note: Version 0.14.x requires PHP 7.2 or later., so I'm assuming version 0.13.x works with PHP7.1, but I have not tested this.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
ubuntu-latest

PHP versions
7.1

To Reproduce

with:
    php-version: 7.1
    tools: phive

Expected behavior
run: phive install --force-accept-unsigned works without issues

Screenshots/Logs

Run phive install --force-accept-unsigned
  phive install --force-accept-unsigned
  shell: /bin/bash -e {0}
Phive requires PHP 7.2 or later; Upgrading to the latest version of PHP is highly recommended. (Version used: 7.1.33-24+ubuntu18.04.1+deb.sury.org+1)

Error: Process completed with exit code 1.

Additional context

Are you willing to submit a PR?

Not likely at the moment as I can work around it, but maybe in the future when I have some free time

@dbrekelmans dbrekelmans added the bug Something isn't working label Dec 13, 2020
@shivammathur
Copy link
Owner

shivammathur commented Dec 13, 2020

@dbrekelmans
Yes, unless you specify the version of the tool, it will install the latest version.

To install say phive 0.13.5, you can specify the version.

- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
     php-version: '7.1'
     tools: phive:0.13.5

To setup different versions of phive with different PHP versions, you can use the matrix.

jobs:
  phive:
    runs-on: ubuntu-latest
    strategy:
      matrix:      
        php-versions: ['7.2', '7.3']
        phive-versions: ['latest']
        
        # Include special cases
        include:
        - php-versions: '7.1'
          phive-versions: '0.13.5'
    steps:
    - name: Setup PHP
      uses: shivammathur/setup-php@v2
      with:
        php-version: ${{ matrix.php-versions }}
        tools: phive:${{ matrix.phive-versions }}

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/418759844/workflow

@shivammathur shivammathur added workflow-edit Issue can be fixed by editing the GitHub Action workflow and removed bug Something isn't working labels Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow-edit Issue can be fixed by editing the GitHub Action workflow
Projects
None yet
Development

No branches or pull requests

2 participants