Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure extension #419

Closed
1 task done
TheLevti opened this issue Feb 27, 2021 · 3 comments
Closed
1 task done

Configure extension #419

TheLevti opened this issue Feb 27, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheLevti
Copy link

TheLevti commented Feb 27, 2021

Describe the feature

Some extensions are configurable so that non default functionality can be enabled or added. One example is the phpredis extension. When installed from pecl, it asks one whether support for igbinary, msgpack and lzf should be enabled. In addition via build configuration options one can enable additional support for lz4 and zstd via:

./configure [--enable-redis-igbinary] [--enable-redis-msgpack] [--enable-redis-lzf [--with-liblzf[=DIR]]] [--enable-redis-zstd] ...

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue

I recently added a pull request to laravel/framework (laravel/framework#36412) to add support for phpredis's serialization/compression support, but could not find the possibility to configure phpredis on installation for the test stage in the pipeline. So now all tests that require this functionality are skipped, because these features are disabled by the default phpredis extension.

Describe alternatives

Add the possibility to specify the options when ./configure is run.

Additional context

Already described in detail my concern :).

Are you willing to submit a PR?

Unfortunately I see this project the first time and it is a bit overwhelming to understand how it works. I can help of course :)

@TheLevti TheLevti added the enhancement New feature or request label Feb 27, 2021
@shivammathur
Copy link
Owner

@TheLevti

This feature will be likely in next release.

It can be tracked here - #418

@TheLevti
Copy link
Author

@TheLevti

This feature will be likely in next release.

It can be tracked here - #418

Awesome, thank you!

@shivammathur
Copy link
Owner

Added in 2.11.0.
Please refer to this guide for more details.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants