Update Phive configuration #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivammathur
reviewed
Aug 1, 2021
jrfnl
force-pushed
the
feature/update-phive-config
branch
from
9c4627b
to
1fdc66c
Compare
This comment has been minimized.
This comment has been minimized.
Phive has released version `0.15.0` which ups the minimum supported PHP version to PHP 7.3. This adds the switch statement for Phive to take this into account. Ref: https://github.com/phar-io/phive/releases
jrfnl
force-pushed
the
feature/update-phive-config
branch
from
1fdc66c
to
f31d416
Compare
|
I have merged this, the develop branch had some test commits which I will clean up later, sorry for the confusion. |
|
@shivammathur No worries. Glad I was finally able to contribute something back. |
shivammathur
added a commit
that referenced
this pull request
Aug 1, 2021
Update Phive configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: ⚙ Improvement
about: Update Phive configuration
labels: enhancement
Description
Phive has released version
0.15.0which ups the minimum supported PHP version to PHP 7.3.This updates the switch statement for Phive to take this into account.
Ref: https://github.com/phar-io/phive/releases
npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.P.S.: Hope I've done it right as I'm not familiar with writing code for GH actions.