Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a "nightly" alias #491

Closed
williamdes opened this issue Sep 5, 2021 · 5 comments
Closed

Add support for a "nightly" alias #491

williamdes opened this issue Sep 5, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@williamdes
Copy link

williamdes commented Sep 5, 2021

Describe the bug

I had to comment out the next PHP 8.2 version as it does not exist yet for this action.
See: phpmyadmin/sql-parser@dd2f634

TravisCI (sorry to mention it, I would prefer that we forget about it) had support for "nightly" in the php version matrix. This was helpfull

Are you willing to submit a PR?
Sorry, I am missing time

@williamdes williamdes added the bug Something isn't working label Sep 5, 2021
@williamdes
Copy link
Author

Ah, form mistake, not a bug

@shivammathur
Copy link
Owner

shivammathur commented Sep 6, 2021

@williamdes
8.2 should work and set up 8.2.0-dev from the master branch of php. I added builds last week. The docs will be updated in the next release.
Test workflow: https://github.com/shivammathur/setup-php/runs/3496421413?check_suite_focus=true#step:6:1

In Travis, IMHO this was broken as they won't update the nightly as it would shift to the next to next version (8.2) and you would not be testing the next version (8.1) in your workflow until support is added for it and you add it to your workflow.

Instead of a nightly tag, I would rather prefer that for testing master, projects add the version in master (8.2) in the workflow. But if you prefer a nightly tag I will add it in the next release.

@shivammathur
Copy link
Owner

Added in develop (d068c17). It Will be in the next release.
Test workflow; https://github.com/shivammathur/test-setup-php/actions/runs/1204939520/workflow

@williamdes
Copy link
Author

Added in develop (d068c17). It Will be in the next release.
Test workflow; https://github.com/shivammathur/test-setup-php/actions/runs/1204939520/workflow

Thank you so much!
Will wait for the release and apply this on all repos

@shivammathur shivammathur added enhancement New feature or request and removed bug Something isn't working labels Sep 6, 2021
@shivammathur
Copy link
Owner

Released in 2.14.0

williamdes added a commit to phpmyadmin/sql-parser that referenced this issue Sep 12, 2021
Ref: shivammathur/setup-php#491

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants