Tools: add support for phpDocumentor #498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 馃帀 New Feature
about: Add a new feature
labels: enhancement
A Pull Request should be associated with a Discussion.
Related discussion: #497
Description
This PR adds support for the phpDocumentor tool via the
tools
input to setup-php.phpDocumentor has also been aliased to
phpdoc
for convenience.I have added a test to the
linux
test for the base name and to thedarwin
test for the alias.馃憠馃徎 Should I also add a test to the
windows
test ?馃憠馃徎 Should I add a test for downloading different versions ?
npm run format
before the commit.npm run lint
before the commit.npm run release
before the commit.npm test
returns with no unit test errors and all code covered.Note: running these scripts, automatically added two unrelated changes to the PR, which I have manually removed (had to disable the
pre-commit
hook to do so). The changes were topackage-lock.json
and todist/index.js
. Not sure what's going on there.