Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: add support for PHP Parallel Lint #500

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 20, 2021


name: 馃帀 New Feature
about: Add a new feature
labels: enhancement

A Pull Request should be associated with a Discussion.

Fixes #499

Description

This PR adds support for the PHP Parallel Lint tool via the tools input to setup-php.

I have added a test to the linux test.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@jrfnl jrfnl force-pushed the feature/tools-add-parallel-lint branch from 404d40d to 257e4c0 Compare September 20, 2021 00:22
@shivammathur shivammathur merged commit 28853c9 into shivammathur:develop Sep 20, 2021
@shivammathur
Copy link
Owner

@jrfnl Thanks

@jrfnl jrfnl deleted the feature/tools-add-parallel-lint branch September 20, 2021 01:04
@jrfnl jrfnl mentioned this pull request Sep 20, 2021
1 task
@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 21, 2021

Integration test:

@shivammathur
Copy link
Owner

@jrfnl Thanks for testing, I will create a release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants