Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: add support for PHPUnit Polyfills #502

Closed
1 task done
jrfnl opened this issue Sep 20, 2021 · 2 comments
Closed
1 task done

Tools: add support for PHPUnit Polyfills #502

jrfnl opened this issue Sep 20, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Sep 20, 2021

Describe the feature
Would be great if the PHPUnit Polyfills Composer package would be available straight from tools.

Ref: https://github.com/Yoast/PHPUnit-Polyfills

Note: PHPUnit Polyfills has a (Composer) dependency on PHPUnit, but once installed, tests can be run both via Composer as well as via a PHPUnit PHAR file.
I'm not sure whether that would add extra complexity to an implementation for this ?

Full disclosure: I'm the author of the PHPUnit Polyfills package.

The package was released end of October last year and has reached (nearly) one million downloads already, so the uptake of projects using it is extensive (and still growing).

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
This tool is typically used to make test suites cross-version compatible with multiple PHPUnit versions.

Are you willing to submit a PR?
Yes, happy to, if you are open to adding the tool.

@jrfnl jrfnl added the enhancement New feature or request label Sep 20, 2021
@shivammathur
Copy link
Owner

@jrfnl

Go ahead with the PR 🚀

This should work.

"phpunit-polyfills": {
  "type": "composer",
  "repository": "yoast/phpunit-polyfills"
}

@jrfnl jrfnl mentioned this issue Sep 20, 2021
7 tasks
@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Sep 20, 2021
@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 20, 2021

Closed as fixed via #503

@jrfnl jrfnl closed this as completed Sep 20, 2021
@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants