Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: add PHPUnit Polyfills #503

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 20, 2021


name: 馃帀 New Feature
about: Add a new feature
labels: enhancement

A Pull Request should be associated with a Discussion.

Fixes #502

Description

This PR adds support for the PHPUnit Polyfills tool via the tools input to setup-php.

I have added a test to the linux test and a second test with a specific version to the darwin test.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

Note: running these scripts, automatically added two unrelated changes to the PR, which I have manually removed (had to disable the pre-commit hook to do so). The changes were to package-lock.json and to dist/index.js. Not sure what's going on there.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

Copy link
Owner

@shivammathur shivammathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dist/index.js.bak file from the PR.

@jrfnl jrfnl force-pushed the feature/tools-add-phpunit-polyfills branch from 2fecd25 to 2c8682d Compare September 20, 2021 14:04
@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 20, 2021

Yikes! Sorry about that, not sure how that got in there as I have a git global ignore set up for those type of files... Either way, should be fixed now.

@shivammathur shivammathur merged commit e820a5d into shivammathur:develop Sep 20, 2021
@shivammathur
Copy link
Owner

@jrfnl Thanks!

@jrfnl jrfnl deleted the feature/tools-add-phpunit-polyfills branch September 20, 2021 14:19
@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 20, 2021

Thanks @shivammathur !

@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 21, 2021

Integration test:

@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 21, 2021

FYI: I've added an FAQ section to the README for the PHPUnit Polyfills about using it via setup-php with tools:
https://github.com/Yoast/PHPUnit-Polyfills#q-how-do-i-run-my-tests-when-the-library-is-installed-via-the-github-actions-setup-php-action-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants