Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action workflow to publish setup-php to NPM and GitHub Packages #507

Closed
shivammathur opened this issue Sep 24, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@shivammathur
Copy link
Owner

Currently, after every release, I manually update the NPM package. A workflow can be added to do this when a new release tag is created. Also the same can start publishing to GitHub Packages as well.

Ref:

@shivammathur shivammathur added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 24, 2021
@aneeshrelan
Copy link
Contributor

Hey, is this something I can take a stab at? Any specific way/approach you have in mind? Using something like semantic-release...?

@shivammathur
Copy link
Owner Author

shivammathur commented Oct 4, 2021

@aneeshrelan Yes, feel free to submit a PR.

With this, we just want to automate publishing to NPM and GH Packages, not complete releases. So semantic-release is not required.

If you go through this guide by GitHub, it has the workflow for publishing to NPM and GH Packages. You just have to implement it in setup-php.

If you have any questions about anything in the workflow, you can use this GitHub Actions reference or ask me here.

@aneeshrelan
Copy link
Contributor

Thanks for the help @shivammathur. I'll have something ready soon

@aneeshrelan
Copy link
Contributor

@shivammathur Do you want to run some other jobs before releasing? Like lint and/or tests or a simple publish is sufficient?

@shivammathur
Copy link
Owner Author

For every commit eslint is run in the node workflow, so in this workflow we can just publish.

@shivammathur
Copy link
Owner Author

Added in #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
No open projects
setup-php-tasks
  
Awaiting triage
Development

No branches or pull requests

2 participants