Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github action to publish to npm and github packages #513

Conversation

aneeshrelan
Copy link
Contributor


name: ⚙ Improvement
about: Adding Github Actions to automatically publish to NPM and Github packages on creating a release
labels: enhancement


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: #507

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR adds a new Github action triggered on a release creation to automatically publish to NPM and Github Packages

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request - NA
  • I have run npm run format before the commit. - NA
  • I have run npm run lint before the commit. - NA
  • I have run npm run release before the commit. - NA
  • npm test returns with no unit test errors and all code covered. - NA

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax. - >NA
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link). - NA

@aneeshrelan
Copy link
Contributor Author

@shivammathur I seem to have tried it locally using act with a --dry-run. I wasn't sure of the Github publish since the guide mentions the scope

@shivammathur
Copy link
Owner

@aneeshrelan Great work, setup-php on NPM is unscoped, and that should work. but if there is an issue with GitHub Packages, I will fix it at the time of release.

Merging it.

@shivammathur shivammathur merged commit 4ce6f3c into shivammathur:develop Oct 5, 2021
@shivammathur
Copy link
Owner

Thanks for the contribution 🎉

@shivammathur shivammathur added awaiting-release Added/Fixed and tested, awaiting release hacktoberfest-accepted labels Oct 5, 2021
@aneeshrelan aneeshrelan deleted the feature/automate-publish-to-npm-github branch October 5, 2021 18:19
@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants