Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlsrv installation stopped working on PHP 7.3 #536

Closed
2 tasks done
hrach opened this issue Dec 7, 2021 · 2 comments
Closed
2 tasks done

sqlsrv installation stopped working on PHP 7.3 #536

hrach opened this issue Dec 7, 2021 · 2 comments
Assignees
Labels
workflow-edit Issue can be fixed by editing the GitHub Action workflow

Comments

@hrach
Copy link

hrach commented Dec 7, 2021

Describe the bug
Suddenly installation on sqlsrv extension stopped working on PHP 7.3

Version

  • v2

Runners

  • GitHub Hosted

Operating systems
Linux.

PHP versions
7.3

To Reproduce
https://github.com/nextras/orm/blob/main/.github/workflows/build.yml

Expected behavior
sqlsrv driver is installed

Screenshots/Logs

✗ sqlsrv-5.10.0 Could not install sqlsrv-5.10.0 on PHP 7.3.33

https://github.com/nextras/orm/runs/4433963038?check_suite_focus=true#step:7:25

Additional context
It worked before.

Are you willing to submit a PR?
No idea how to fix.

@hrach hrach added the bug Something isn't working label Dec 7, 2021
@shivammathur
Copy link
Owner

@hrach
PECL extension versions do not have hyphen in them, so sqlsrv-5.10.0-beta2 should be sqlsrv-5.10.0beta2
Ref: https://pecl.php.net/package/sqlsrv

That aside, I have added a patch to handle this typo in a274bd9

Please restart your workflow, it should work correctly now. Test workflow
If you want you can remove the hyphen in 5.10.0-beta2 to be 5.10.0beta2.

@shivammathur shivammathur added workflow-edit Issue can be fixed by editing the GitHub Action workflow and removed bug Something isn't working labels Dec 7, 2021
@hrach
Copy link
Author

hrach commented Dec 9, 2021

Thanks a lot. What I didn't understand:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow-edit Issue can be fixed by editing the GitHub Action workflow
Projects
None yet
Development

No branches or pull requests

2 participants