Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sed: illegal option -- r in MacOS #680

Closed
2 of 5 tasks
Jeckerson opened this issue Dec 26, 2022 · 5 comments
Closed
2 of 5 tasks

sed: illegal option -- r in MacOS #680

Jeckerson opened this issue Dec 26, 2022 · 5 comments
Assignees
@shivammathur
Labels
bug Something isn't working

Comments

@Jeckerson
Copy link

Jeckerson commented Dec 26, 2022 •
edited

Describe the bug
MacOS runs failing.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
MacOS

PHP versions
Any

To Reproduce
https://github.com/zephir-lang/zephir/actions/runs/3783117341/jobs/6431403311#step:3:28
@Jeckerson Jeckerson added the bug Something isn't working label Dec 26, 2022
@shivammathur
Copy link
Owner

@Jeckerson

I could not reproduce this, Please point me to the workflow where the error is, or provide me the YAML for the setup-php step.

https://github.com/shivammathur/test-setup-php/actions/runs/3783581421/workflow

@Jeckerson
Copy link
Author

@shivammathur https://github.com/zephir-lang/zephir/actions/runs/3783117341/jobs/6431403311#step:3:28

URL was inside comment.

@shivammathur
Copy link
Owner

@Jeckerson

I will fix that, but this error is not why your CI is failing.

macos-10.15 is no longer supported by homebrew, Please upgrade your runner to macos-11 or macos-12 preferably.
Ref: https://docs.brew.sh/Installation#2

@shivammathur
Copy link
Owner

Fixed in 40846b2

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Dec 26, 2022
@shivammathur
Copy link
Owner

Released the fix in 2.24.0

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shivammathur @Jeckerson