Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .php-version file for version detection #690

Merged
merged 1 commit into from Jan 29, 2023

Conversation

stevelacey
Copy link
Contributor

@stevelacey stevelacey commented Jan 29, 2023


name: 🎉 New Feature
about: Support reading PHP version from file when version is not explicitly supplied, defaults to .php-version
labels: enhancement


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: #629

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR [briefly explain what it does]

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@stevelacey stevelacey force-pushed the php-version-file branch 3 times, most recently from 2cac96a to 4d2e5ba Compare January 29, 2023 05:40
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #690 (fd03521) into develop (baf9535) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #690   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          539       554   +15     
  Branches        81        85    +4     
=========================================
+ Hits           539       554   +15     
Impacted Files Coverage Δ
src/utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shivammathur shivammathur merged commit 2d47531 into shivammathur:develop Jan 29, 2023
@shivammathur
Copy link
Owner

@stevelacey Thanks for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants