Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not pick thread safe version of zephir_parser package #701

Closed
2 of 5 tasks
Jeckerson opened this issue Feb 9, 2023 · 4 comments
Closed
2 of 5 tasks

Does not pick thread safe version of zephir_parser package #701

Jeckerson opened this issue Feb 9, 2023 · 4 comments
Assignees
@shivammathur
Labels
bug Something isn't working

Comments

@Jeckerson
Copy link

Describe the bug
It always picks one type.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Any

PHP versions
Any

To Reproduce
https://github.com/zephir-lang/zephir/actions/runs/4132412865/jobs/7141078939#step:6:122
@Jeckerson Jeckerson added the bug Something isn't working label Feb 9, 2023
@shivammathur
Copy link
Owner

Fixed in 0d60024

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Feb 9, 2023
@Jeckerson
Copy link
Author

https://github.com/zephir-lang/zephir/actions/runs/4136608309/jobs/7150711424#step:3:31

Extension wasn't installed.

@shivammathur
Copy link
Owner

shivammathur commented Feb 9, 2023 •
edited

@Jeckerson Try with shivammathur/setup-php@develop. I fixed another bug in the next commit for enabling extensions.

@Jeckerson
Copy link
Author

It works, thank you!

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shivammathur @Jeckerson