Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if setup-php was unable to install the requested PHP version #709

Closed
1 task done
weirdan opened this issue Mar 13, 2023 · 2 comments
Closed
1 task done

Fail if setup-php was unable to install the requested PHP version #709

weirdan opened this issue Mar 13, 2023 · 2 comments
Assignees
@shivammathur
Labels
enhancement New feature or request

Comments

@weirdan
Copy link

weirdan commented Mar 13, 2023

Describe the feature

setup-php should fail when it's unable to install the requested PHP version

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue

Currently, when setup-php fails to set up the requested PHP version, the build continues with the PHP version provided by the runner environment, which may not be compatible with the software being built/tested.

Describe alternatives

I tried to use env: fail-fast: true to no avail.

Additional context

image

This happens intermittently but quite often, so I couldn't run it with debugging enabled.

https://github.com/vimeo/psalm/actions/runs/4401974668/jobs/7708673538

Are you willing to submit a PR?

I'm not sure I'll be able to do this.
@weirdan weirdan added the enhancement New feature or request label Mar 13, 2023
@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Mar 14, 2023
@shivammathur
Copy link
Owner

Fixed in 5f42281.

Will be in the next release.

@shivammathur
Copy link
Owner

Fix released in 2.25.0.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weirdan @shivammathur