Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using extensions with none leads to unexpected result across the operating systems #749

Closed
2 of 4 tasks
kubawerlos opened this issue Jul 11, 2023 · 3 comments
Closed
2 of 4 tasks
Assignees
Labels
bug Something isn't working

Comments

@kubawerlos
Copy link

Describe the bug

Version

  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Ubuntu, Windows, and macOS, when macOS is especially painful.

PHP versions
8.2

To Reproduce
Workflow and it's summary: https://github.com/werlos/github-actions-php-extensions

Expected behavior
using none followed by opcache should behave the same (by enabling OPcache) for all the operating systems.

Screenshots/Logs
See the action in mentioned repo.

Additional context
Is it how operating systems (or homebrew?) differently treat what is "shared extension"?

Are you willing to submit a PR?
If I will be able to, need at least some guidance how target the problem.

@shivammathur
Copy link
Owner

Fixed re-enabling opcache on macOS in 5b2015e. Will be in the next release.

It was not working correctly as homebrew installs the extension in a different directory than php's extension directory.

@shivammathur shivammathur added awaiting-release Added/Fixed and tested, awaiting release and removed awaiting-release Added/Fixed and tested, awaiting release labels Jul 29, 2023
@shivammathur
Copy link
Owner

Fix released in 2.25.5

@kubawerlos
Copy link
Author

Thank you @shivammathur 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants