Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use any php extension, ex support sqlsrv extension for Windows and php 8.2 #758

Closed
Max84 opened this issue Aug 17, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Max84
Copy link

Max84 commented Aug 17, 2023

Describe the feature
We can install any php extension, even onto PECL, but only if a DLL exists.
For example, it doesn't possible to use the sqlsrv extension on Windows if we use php 8.2 because the DLL doesn't exist onto PECL website.
But Microsoft already provides this DLL.
A good feature can be to allow us to use any DLL, even it's not a PECL DLL.

Version

  • [ x] I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
N/A

Describe alternatives
N/A

Additional context
N/A

Are you willing to submit a PR?
I'm not really fluent with TS :(

@Max84 Max84 added the enhancement New feature or request label Aug 17, 2023
@Max84
Copy link
Author

Max84 commented Aug 17, 2023

If it can help, these is a way to get the extension:

`- uses: shivammathur/setup-php@v2
with:
php-version: '8.2.9'
extensions: curl,fileinfo,gd,gettext,gmp,imap,mbstring,mysqli,odbc,openssl,pdo_sqlite,pgsql,soap,sockets,sodium,sqlite3,tidy,xsl,zip,php_com_dotnet,bz2

  - name: Install Custom Extension
    run: |
      mkdir extensions
      Invoke-WebRequest -Uri https://github.com/microsoft/msphpsql/releases/download/v5.11.0/Windows-8.2.zip -OutFile extensions\sqlsrv.zip
      Expand-Archive -Path extensions\sqlsrv.zip -DestinationPath extensions

  - name: Configure PHP with Custom Extension
    run: |           
        cp extensions\Windows-8.2\x64\php_sqlsrv_82_nts.dll C:\tools\php\ext\
        echo extension=php_sqlsrv_82_nts.dll >> C:\tools\php\php.ini`

@GrahamCampbell
Copy link
Contributor

This is partially fixed, in the sense that the installed version will work on PHP up to and including 8.2, #766, once this is included in a tagged release.

@shivammathur
Copy link
Owner

Released 2.26.0 with the fix.

@Max84
Copy link
Author

Max84 commented Sep 18, 2023

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants