Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug symbols not included in libphp 8.3 ZTS even when debug set to true #784

Closed
3 of 5 tasks
dunglas opened this issue Nov 16, 2023 · 2 comments
Closed
3 of 5 tasks
Assignees
Labels
bug Something isn't working

Comments

@dunglas
Copy link

dunglas commented Nov 16, 2023

Describe the bug
libphp8.3.so ZTS is stripped even when debug is true.

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Ubuntu 22.04.3 LTS

PHP versions
PHP 8.3 nightly

To Reproduce

     -
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.3
          ini-file: development
          coverage: none
          tools: none
        env:
          phpts: ts
          debug: true

Expected behavior
Debug symbols should be included.

Screenshots/Logs

$ file /usr/lib/libphp8.3.so
/usr/lib/libphp8.3.so: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=0aaebe820406e66a76acb2588689bc16bbd023dc, stripped

Additional context
n/a

Are you willing to submit a PR?
yes

@shivammathur
Copy link
Owner

@dunglas

Fixed in shivammathur/php-builder@66b1f71

The file command would still say stripped at the end, but the debug files should be there in the correct directory in /usr/lib/debug/ and the debugger should pick debuginfo from them.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/6902553939/workflow

@dunglas
Copy link
Author

dunglas commented Nov 17, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants