Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce commitlint to enforce commit message format #475

Closed
kalpeshsingh opened this issue Sep 11, 2020 · 1 comment
Closed

Introduce commitlint to enforce commit message format #475

kalpeshsingh opened this issue Sep 11, 2020 · 1 comment

Comments

@kalpeshsingh
Copy link
Contributor

kalpeshsingh commented Sep 11, 2020 •
edited

This is part of main issue #457

Motivation

Sometimes it is wise to have automated tools to enforce development standards rather than relying on team communication. We are introducing commitlint package that will help us to promote standard commit message.

It won't allow developers to commit until they use cz for proper commit message format or write manually formatted message.

Steps to achieve

  • Add commitlint.config.js file for configuration
module.exports = {extends: ['@commitlint/config-conventional']}
  • Add npm packages
  1. @commitlint/cli
  2. @commitlint/config-conventional
  • Add commit-msg hook in gitHooks

Resources
kalpeshsingh added a commit to kalpeshsingh/frontend.social that referenced this issue Sep 11, 2020
@kalpeshsingh
chore: enforce commit message formate using commitlint
4439275 
shoonyatech#475
@kalpeshsingh kalpeshsingh changed the title Introduce commitlint to enforce commit message Introduce commitlint to enforce commit message format Sep 11, 2020
@kalpeshsingh kalpeshsingh mentioned this issue Sep 11, 2020
Merged
kalpeshsingh added a commit to kalpeshsingh/frontend.social that referenced this issue Sep 11, 2020
@kalpeshsingh
chore: enforce commit message formate using commitlint (#4)
c1524fe 
shoonyatech#475
@kalpeshsingh kalpeshsingh mentioned this issue Sep 11, 2020
Closed
kalpeshsingh added a commit to kalpeshsingh/frontend.social that referenced this issue Sep 26, 2020
@kalpeshsingh
chore: enforce commit message formate using commitlint
73cd3c1 
shoonyatech#475
kalpeshsingh added a commit to kalpeshsingh/frontend.social that referenced this issue Sep 26, 2020
@kalpeshsingh
chore: enforce commit message formate using commitlint (#4)
0b0e227 
shoonyatech#475
kalpeshsingh added a commit to kalpeshsingh/frontend.social that referenced this issue Sep 26, 2020
@kalpeshsingh
Add commitlint (#5)
550cdf7 
* chore: enforce commit message formate using commitlint

shoonyatech#475

* build(frontend.social): add prettier to format files

add prettier script, configuration file and add it in lint-staged to format and again add formatted
files during git commit

shoonyatech#466

* Prettier integration (#3)

* chore(package.json): add prettier and remove file glob from format script

* chore(package.json): updgrade lint-stage dependency for improvement

* chore: enforce commit message formate using commitlint

shoonyatech#475
This was referenced Sep 26, 2020
Closed
Merged
kalpeshsingh added a commit to kalpeshsingh/frontend.social that referenced this issue Sep 26, 2020
@kalpeshsingh
style(project): format all the files, add command for the same and up…
2374120 
…date readme with example

shoonyatech#475
@kalpeshsingh kalpeshsingh mentioned this issue Sep 26, 2020
Merged
souvikbasu pushed a commit that referenced this issue Sep 26, 2020
@kalpeshsingh @souvikbasu
style(project): format all the files, add command for the same and up…
18d0f6b 
…date readme with example

#475
@kalpeshsingh
Copy link
Contributor Author

Closing this as PR is merged.
Thank you @souvikbasu 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kalpeshsingh