Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffEngine compatibility issues #939

Open
gtbuchanan opened this issue Apr 17, 2024 · 0 comments
Open

DiffEngine compatibility issues #939

gtbuchanan opened this issue Apr 17, 2024 · 0 comments

Comments

@gtbuchanan
Copy link

DiffEngine 14 dropped support for Shouldly's current target frameworks netstandard2.0 and net5.0 and added a new optional Encoding argument for DiffRunner.Launch. The latest version of Verify uses DiffEngine 15. This causes the following runtime error when referencing both Shouldly and Verify and calling ShouldMatchApproved:

System.MissingMethodException : Method not found: 'DiffEngine.LaunchResult DiffEngine.DiffRunner.Launch(System.String, System.String)'.
ShouldMatchApprovedTestExtensions.ShouldMatchApproved(String actual, Action`1 configureOptions, String customMessage)

I was initially going to submit a PR to bump DiffEngine but realized this resulted in more drastic changes. In order to support the new DiffEngine and resolve this issue, Shouldly would have to target net472 and net6.0 at a minimum (dropping netstandard altogether). Is this something you're willing to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant