fix(openLinksInNewWindow): hash links are not affected by the option

Closes #457
showdownjs · Nov 11, 2017 · 11936ec · 11936ec
1 parent c956ede
commit 11936ec
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 5 deletions.
diff --git a/dist/showdown.js b/dist/showdown.js
diff --git a/dist/showdown.js.map b/dist/showdown.js.map
diff --git a/dist/showdown.min.js b/dist/showdown.min.js
diff --git a/dist/showdown.min.js.map b/dist/showdown.min.js.map
diff --git a/src/subParsers/anchors.js b/src/subParsers/anchors.js
@@ -44,7 +44,9 @@ showdown.subParser('anchors', function (text, options, globals) {
       result += ' title="' + title + '"';
     }
 
-    if (options.openLinksInNewWindow) {
+    // optionLinksInNewWindow only applies
+    // to external links. Hash links (#) open in same page
+    if (options.openLinksInNewWindow && !/^#/.test(url)) {
       // escaped _
       result += ' target="¨E95Eblank"';
     }

diff --git a/test/features/openLinksInNewWindow/hash-links-open-in-same-page.html b/test/features/openLinksInNewWindow/hash-links-open-in-same-page.html
@@ -0,0 +1 @@
+<p>this link is in the <a href="#same-page">same page</a></p>
diff --git a/test/features/openLinksInNewWindow/hash-links-open-in-same-page.md b/test/features/openLinksInNewWindow/hash-links-open-in-same-page.md
@@ -0,0 +1 @@
+this link is in the [same page](#same-page)