Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML broke markdown parsing #220

Closed
ferllings opened this issue Nov 20, 2015 · 6 comments
Closed

HTML broke markdown parsing #220

ferllings opened this issue Nov 20, 2015 · 6 comments
Assignees
Labels

Comments

@ferllings
Copy link

Hello,

I ran into an issue when having multiple HTML raw code inside a long Markdown document.

I reduced the code into the minimal reproductible sample:

Title 1
-------

<div></div>

# Title 2

<div>
</div>

It produce

Title 1
# Title 2

The Title 2 is not converted to html

You can try it on http://showdownjs.github.io/demo/

@tivie tivie self-assigned this Nov 20, 2015
@tivie tivie added duplicate and removed duplicate labels Nov 20, 2015
@ferllings
Copy link
Author

Hello,

Any confirmation about this bug?

@tivie
Copy link
Member

tivie commented Dec 1, 2015

Yes, I'm currently looking into it, I expect to have a fix soon.

@ferllings
Copy link
Author

Thanks a lot!

@tivie
Copy link
Member

tivie commented Jan 1, 2016

Ok, this issue took a lot longer than expected. I had to make quite some changes in hashHTMLBlock in order to make it work smarter.

This issue should be fixed now in commit 2746949.

@ferllings Do you mind testing it a bit further?

@matatk
Copy link

matatk commented Jan 3, 2016

Of course we should leave it to @ferllings, as the OP, to confirm, but I thought I'd say that this fix does seem to work very well from my perspective; thank you!

@tivie
Copy link
Member

tivie commented Jan 3, 2016

thanks @matatk

@tivie tivie added the bug label Jan 4, 2016
@tivie tivie closed this as completed in 2746949 Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants