Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of GFM tables with missing leading/trailing pipes #230

Closed
DoumanAsh opened this issue Jan 24, 2016 · 6 comments
Closed
Assignees

Comments

@DoumanAsh
Copy link

If you have missing leading or/and trailing | then table will not be rendered correctly

Example

|Markdown | Less | Pretty
|--- | --- | ---
|*Still* | `renders` | **nicely**
|1 | 2 | 3
@DoumanAsh DoumanAsh changed the title Incorrect parsing of GFM tables Incorrect parsing of GFM tables with missing leading/trailing pipes Jan 24, 2016
@tivie
Copy link
Member

tivie commented Jan 25, 2016

Duplicate: #226

Also check the wiki page: https://github.com/showdownjs/showdown/wiki/Showdown's-Markdown-syntax#tables

Keep in mind that, contrary to GFM, the outer pipes (|) are NOT optional. But you don't need to make the raw Markdown line up prettily.

@tivie tivie self-assigned this Jan 25, 2016
@DoumanAsh
Copy link
Author

Oh sorry. It would be good to have that as feature, but if it is not possible since it conflicts with Snowdown specs then please feel free to close issue

tivie added a commit that referenced this issue Jan 25, 2016
Now Leading and trailing pipes (|) are optional in tables

Closes #230
@tivie
Copy link
Member

tivie commented Jan 25, 2016

You should be able to use GH spec with tables now

@DoumanAsh
Copy link
Author

Great! Will it be part of default behavior or it is intended as optional feature?

@tivie
Copy link
Member

tivie commented Jan 25, 2016

default, as the older table style is fully supported as well.

@DoumanAsh
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants