Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code blocks containing xml comments are not converted correctly when nested in list items #288

Closed
reversemerman opened this issue Aug 29, 2016 · 8 comments
Closed

Code blocks containing xml comments are not converted correctly when nested in list items #288

reversemerman opened this issue Aug 29, 2016 · 8 comments
Assignees
@tivie
Labels
bug

Comments

@reversemerman
Copy link

Removing the commented out sections of the XML fixes the issue. These are rendered correctly on GitHub.
@tivie
Copy link
Member

tivie commented Aug 29, 2016 •
edited

Can you create a snippet showing the issue?

@reversemerman reversemerman changed the title Code blocks containing xml comments are not converted correctly Code blocks containing xml comments are not converted correctly when nested in list items Aug 29, 2016
@reversemerman
Copy link
Author

OS: Ubuntu 16.04 LTS

showdown makehtml -i input.txt -o output.txt --tables --ghCodeBlocks

input.txt
output.txt

@tivie tivie self-assigned this Aug 30, 2016
@tivie tivie added the bug label Aug 30, 2016
@tivie
Copy link
Member

tivie commented Aug 30, 2016 •
edited

Confirmed in the online demo.

I will look into this as soon as possible

tivie added a commit that referenced this issue Aug 30, 2016
@tivie
fix(parser): fix issue with comments inside nested code blocks
799abea 
Code blocks containing comments are now converted correctly when nested in list items.

Closes #288
@tivie
Copy link
Member

tivie commented Aug 30, 2016

This should be fixed now.

@tivie tivie closed this as completed Aug 30, 2016
@siriscac
Copy link

siriscac commented Nov 2, 2016

I'm facing this issue again.
Using the npm module. I looked at the code for 799abea changes, and it doesn't seem to have them.

@tivie
Copy link
Member

tivie commented Nov 2, 2016 •
edited

@siriscac, this update was not released yet.

The next showdown version should include it

@tivie
Copy link
Member

tivie commented Nov 2, 2016

Released v 1.4.4 that includes this fix

https://github.com/showdownjs/showdown/releases/tag/1.4.4

@siriscac
Copy link

siriscac commented Nov 7, 2016

Can confirm that it works, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivie tivie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reversemerman @tivie @siriscac