Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option: headerRegex #321

Closed
wants to merge 2 commits into from
Closed

add option: headerRegex #321

wants to merge 2 commits into from

Conversation

veggiemonk
Copy link

fix #320

@veggiemonk veggiemonk mentioned this pull request Dec 30, 2016
Closed
@tivie
Copy link
Member

tivie commented Dec 30, 2016

Thank you very much @veggiemonk
Instead of letting users pass a regex, I prefer to mimic github id parsing rules directly.

@tivie tivie closed this in db97a90 Dec 30, 2016
@veggiemonk
Copy link
Author

Awesome! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

header ID generated are not compatible with ID generated on Github
2 participants
@veggiemonk @tivie