Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed long comment freezes showdown #439

Closed
tivie opened this issue Oct 2, 2017 · 1 comment
Closed

Malformed long comment freezes showdown #439

tivie opened this issue Oct 2, 2017 · 1 comment
Assignees

Comments

@tivie
Copy link
Member

tivie commented Oct 2, 2017

The following input crashes showdown:

<!--------------------------------------------------------------------------------------------------------------------------------------------------

This happens because the comment regex elicits a catastrophic backtrace.

@tivie tivie self-assigned this Oct 2, 2017
@tivie tivie closed this as completed in 3efcd10 Oct 2, 2017
@tivie
Copy link
Member Author

tivie commented Oct 6, 2017

Should be fixed in v 1.7.5


As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money. Currently, we're looking to improve showdown with automated tests in all browsers and a proper domain and webpage. 500$ should be enough to to keep showdown testing framework running for a year or two.

If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant