Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

italicsAndBold.after listener extension shouldn't execute inside code spans #464

Closed
ctsears opened this issue Nov 22, 2017 · 3 comments
Closed

italicsAndBold.after listener extension shouldn't execute inside code spans #464

ctsears opened this issue Nov 22, 2017 · 3 comments
Assignees
@tivie
Labels
bug

Comments

@ctsears
Copy link

ctsears commented Nov 22, 2017

For some reason, italicsAndBold.after listener extensions are working inside code spans. The correctly do not run inside code blocks. Since italicsAndBold doesn't impact code spans, I'm not sure what's going wrong. Fiddle is here: https://jsfiddle.net/s83o24et/11/
@tivie tivie self-assigned this Nov 23, 2017
@tivie tivie added the bug label Nov 23, 2017
@tivie
Copy link
Member

tivie commented Nov 23, 2017

Found the issue. Code spans are not being hashed after parsing. Instead, we're only escaping "magic" markdown chars inside. Since the character + is not magic in markdown, it's not being escaped

tivie added a commit that referenced this issue Nov 23, 2017
@tivie
fix(spanGamut): code spans are hashed after parsing
f4f63c5 
Code spans are now hashed after parsing which means extensions
that listen to spanGamut events no longer need to worry about
escaping "custom" magic chars inside code spans.

Closes #464
@tivie
Copy link
Member

tivie commented Nov 23, 2017

@ctsears This should be fixed now. Please give it a try and tell me if it works.

@ctsears
Copy link
Author

ctsears commented Nov 23, 2017

Working now! Thanks!

@ctsears ctsears closed this as completed Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivie tivie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tivie @ctsears