Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "deep-search" query execution #118

Open
isihu opened this issue Dec 6, 2023 · 2 comments
Open

Create a "deep-search" query execution #118

isihu opened this issue Dec 6, 2023 · 2 comments

Comments

@isihu
Copy link

isihu commented Dec 6, 2023

Hi there,

consider the query of the pagination example in your README.
How about providing a second function that, instead of returning the query as is, would deep-query the result and follow any pageInfo object until HasNextPage is false? The new results can just be appended to the existing one so the return type of the 2 functions wouldn't differ.
The API for it could be

err = ghClient.DeepQuery(ctx, &query, nil)

Do you see anything blocking this? We will need to implement this in the future for our specific use case anyway, might as well make it general and provide a PR here.

Kind regards

@isihu
Copy link
Author

isihu commented Feb 21, 2024

@dmitshur Sorry for ping. Is this something you'd be interested in? I'd be happy to provide a PR

@dmitshur
Copy link
Member

dmitshur commented Feb 24, 2024

This sounds interesting, can you say more about how it would work? Would it only handle one level of pagination or are you thinking about multiple nested levels of pagination too?

I don't know when I'll have time to review a PR for functionality like this, but if you don't mind that feel free to send one, or just a link to where it's already done. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants