Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching to goldmark #56

Open
karelbilek opened this issue Mar 10, 2020 · 6 comments
Open

switching to goldmark #56

karelbilek opened this issue Mar 10, 2020 · 6 comments

Comments

@karelbilek
Copy link

Hello,

blackfriday is too buggy and annoying. :) there is a new go-based markdown parser goldmark, now used in huge instead of blackfriday

https://github.com/yuin/goldmark

we have our own fork of markdownfmt, that uses goldmark now. (And changed a few decisions - instead of 1.[tab]list, we just use 1.[space]list- that we can afford now that we don't use blackfriday with its weird list handling)

unfortunately, we have some hacky and ineffective stuff at some points, as one of our usecases is being able to render just some nodes as bytes. And we explicitly don't support lists inside blockquotes, because I was too lazy to do that

Still it's here

https://github.com/Kunde21/markdownfmt

@bwplotka
Copy link

I found this very useful, thanks for this!

Would love to have one "proper" markdownfmt that we can use and collab on to finish all the edge cases. Wonder if it's not worth to propose is as a PR to this in another markdownv2 package etc? cc @shurcooL

@karelbilek
Copy link
Author

I'm currently quite busy to do this "properly" as a hobby project :(

but it would be nice to take it and finish up, and remove those weird maps that we have there

cc @Kunde21 - and also cc @planetscale @dctrwatson - I saw this fork of our fork :)

https://github.com/planetscale/markdownfmt

@bwplotka
Copy link

bwplotka commented Oct 27, 2020

This is crazy because now I need to fork @planetscale repo to fix #58 😱

Should we do this properly at some point? ;p

@bwplotka
Copy link

bwplotka commented Oct 27, 2020

Maybe at least we could agree on one fork (:

EDIT: Trying my best to avoid fork: Kunde21/markdownfmt#12 and ported one amazing feature of @planetscale Kunde21/markdownfmt#13

@bwplotka
Copy link

BTW, looks like we agreed on one fork.

https://github.com/Kunde21/markdownfmt it is. Actively maintained, feel free to use it. (:

@bwplotka
Copy link

#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants