Alternative Method of Enabling Taskbar

[Andrewcpu]

There's a better way to enable the taskbar for phones.. Currently the method that everyone seems to use is ripping off the isTablet flag of the Taskbar. This works, however it modifies Pixel Launcher's scaling to a stupid small size for a phone.

There's a few different flags that can be set to enable the taskbar without screwing with Pixel Launcher's scaling.. I don't have the time to build a PR at the moment, but I can provide you with what I have from my personal module.

The AOSPMods way of disabling the base gesture pill:

Class<?> NavigationHandleClass = findClass("com.android.systemui.navigationbar.gestural.NavigationHandle", loadPackageParam.classLoader);
hookAllMethods(NavigationHandleClass,
        "setVertical", new XC_MethodHook() {
            @Override
            protected void beforeHookedMethod(MethodHookParam param) throws Throwable {
                View result = (View) param.thisObject;
                ViewGroup.LayoutParams resultLayoutParams = result.getLayoutParams();
                int originalWidth, originalHeight;
                try {
                    originalWidth = (int) getAdditionalInstanceField(param.thisObject, "originalWidth");
                    originalHeight = (int) getAdditionalInstanceField(param.thisObject, "originalHeight");
                } catch (Throwable ignored) {
                    originalWidth = resultLayoutParams.width;
                    originalHeight = resultLayoutParams.height;
                    setAdditionalInstanceField(param.thisObject, "originalWidth", originalWidth);
                    setAdditionalInstanceField(param.thisObject, "originalHeight", originalHeight);
                }
                if(originalWidth != -1){
                    taskWidth = originalWidth;
                    taskHeight = originalHeight;
                }
                resultLayoutParams.width = 0; // sets gesture pill to 0 width
            }
        });

And then for the hook into PixelLauncher:

Class<?> gridIsScalableClass = findClass("com.android.launcher3.InvariantDeviceProfile$GridOption", loadPackageParam.classLoader);
Class<?> deviceProfile = findClass("com.android.launcher3.DeviceProfile", loadPackageParam.classLoader);
Class<?> taskbarStashController = findClass("com.android.launcher3.taskbar.TaskbarStashController", loadPackageParam.classLoader);
Class<?> taskbarStashedHandled = findClass("com.android.launcher3.taskbar.StashedHandleViewController", loadPackageParam.classLoader);
Class<?> taskbarActivityContext = findClass("com.android.launcher3.taskbar.TaskbarActivityContext", loadPackageParam.classLoader);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
    XC_MethodHook cornerRadiusHook = new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            param.setResult(Math.round((int) param.getResult() * 0.9f)); // corner radius modifications
        }
    };
    hookAllMethods(taskbarActivityContext, "getLeftCornerRadius", cornerRadiusHook); // AOSP corner radius mods
    hookAllMethods(taskbarActivityContext, "getRightCornerRadius", cornerRadiusHook);
    hookAllMethods(taskbarStashedHandled, "init", new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            XposedBridge.log("Initializing taskbar taskbarStashedHandled with Width of " + taskWidth);
            taskbarHandle = param.thisObject;
            XposedHelpers.setIntField(param.thisObject, "mStashedHandleWidth", 413);
            XposedHelpers.setIntField(taskController, "mStashedHeight", taskHeight);
        }
    });
    XposedBridge.hookAllConstructors(deviceProfile, new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            XposedHelpers.setObjectField(param.thisObject, "taskbarSize", (int) (Math.round(getIntField(param.thisObject, "iconSizePx") * 0.9)));
            XposedHelpers.setBooleanField(param.thisObject, "isTaskbarPresent", true);
            XposedHelpers.setBooleanField(param.thisObject, "isTaskbarPresentInApps", true);
        }
    });
    XposedBridge.hookAllMethods(deviceProfile, "getHotseatLayoutPadding", new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            Rect rect = new Rect(8, 1, 8, taskbarHeight); // L t R b, bottom spacing is weird, but I'm unsure of where to fix.. This may work
            param.setResult(rect);
        }
    });
    XposedBridge.hookAllConstructors(taskbarStashController, new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            taskController = param.thisObject;
            XposedHelpers.setIntField(param.thisObject, "mStashedHeight", taskHeight);
        }
    });
    XposedBridge.hookAllMethods(taskbarStashController, "getStashedHeight", new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            taskController = param.thisObject;
            param.setResult(taskHeight);
        }
    });
    XposedBridge.hookAllConstructors(gridIsScalableClass, new XC_MethodHook() {
        @Override
        protected void afterHookedMethod(MethodHookParam param) throws Throwable {
            Object o = param.thisObject;
            XposedHelpers.setBooleanField(o, "isScalable", false);
            XposedBridge.log("Disabling scalability of element.");
        }
    });

Instead of an incredibly overscaled launcher, we get:

This method is better than ripping off isTablet because it yields less side effects.. But let me know what you think!

[siavash79]

Wow thanks for your help.

I did try setting isTaskbarPresent few days ago during a short break and didn't get anything out of it.

And since I had to get back to work I didn't really try to track the "why it doesn't work", and just deleted my test.

But if you've tried it successfully I'll give it another try. If it worked at your end it should be okay.

Thanks again

[Andrewcpu]

No problem! :) I will link my repo in a bit just so you can reference if you need.. Also next time I'll open an issue! Didn't mean to interrupt your flow, just figured this was more of a "Discussion" kind of thing over an issue haha.

[siavash79]

And just to add one more thing: this is the very first time I'm visiting the discussions page here, and even this was referred to me by eleo.

I'd be a better idea if you use the issues section in the future

[Andrewcpu]

#543 :)