Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure base to a branch other than master #311

Open
siddharthkp opened this issue Jun 27, 2019 · 1 comment
Open

Configure base to a branch other than master #311

siddharthkp opened this issue Jun 27, 2019 · 1 comment

Comments

@siddharthkp
Copy link
Owner

from @Haroenv: thing which would make it a lot nicer too is if the comparison would be to the base branch on GitHub (instead of always master), since that way you get a pure diff

@siddharthkp siddharthkp created this issue from a note in Road to 1.0.0 (To do) Jun 27, 2019
@siddharthkp siddharthkp added this to the Easier to configure milestone Jun 27, 2019
@Haroenv
Copy link
Collaborator

Haroenv commented Jun 27, 2019

relevant code I think is:

if (currentEvent === 'push' && currentBranch === 'master') {

Here only the master size is persisted, but instead we need to either compute the size of the target branch, or save the state of every branch instead of only master.

Frontend it also requires some changes like changing master to target (or the name of the target)

<div class="light label master">MASTER</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Road to 1.0.0
  
To do
Development

No branches or pull requests

2 participants