Add Amazon RDS certificates for AWS China #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of certificates in the documentation on aws.amazon.com is not comprehensive. It includes the Public and GovCloud certificates, but not the China certificates. As such, connections within AWS CN with the "ssl" key set to "Amazon RDS" fail with "unable to get local issuer certificate".
|
thanks @mrmilosz ! |
|
My pleasure! Thank you for the quick merge @sidorares ! |
Vylpes
pushed a commit
to Vylpes/Droplet
that referenced
this pull request
Sep 14, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mysql2](https://github.com/sidorares/node-mysql2) | dependencies | major | [`^2.2.5` -> `^3.0.0`](https://renovatebot.com/diffs/npm/mysql2/2.2.5/3.2.4) | --- ### Release Notes <details> <summary>sidorares/node-mysql2</summary> ### [`v3.2.4`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​324-httpsgithubcomsidoraresnode-mysql2comparev323v324-2023-04-25) [Compare Source](sidorares/node-mysql2@v3.2.3...v3.2.4) ##### Bug Fixes - **server:** Added missing encoding argument to server-handshake ([#​1976](sidorares/node-mysql2#1976)) ([a4b6b22](sidorares/node-mysql2@a4b6b22)) ### [`v3.2.3`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​323-httpsgithubcomsidoraresnode-mysql2comparev322v323-2023-04-16) [Compare Source](sidorares/node-mysql2@v3.2.2...v3.2.3) ##### Bug Fixes - **types:** add decimalNumbers to createConnection/createPool typings. fixes [#​1803](sidorares/node-mysql2#1803) ([#​1817](sidorares/node-mysql2#1817)) ([bb48462](sidorares/node-mysql2@bb48462)) ### [`v3.2.2`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​322-httpsgithubcomsidoraresnode-mysql2comparev321v322-2023-04-16) [Compare Source](sidorares/node-mysql2@v3.2.1...v3.2.2) ##### Bug Fixes - `ConnectionOptions` conflict between `mysql` and `mysql/promise` ([#​1955](sidorares/node-mysql2#1955)) ([eca8bda](sidorares/node-mysql2@eca8bda)) ### [`v3.2.1`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​321-httpsgithubcomsidoraresnode-mysql2comparev320v321-2023-04-13) [Compare Source](sidorares/node-mysql2@v3.2.0...v3.2.1) ##### Bug Fixes - Add typings for Connection.promise(). ([#​1949](sidorares/node-mysql2#1949)) ([e3ca310](sidorares/node-mysql2@e3ca310)) - PoolConnection redundancy when extending Connection interface in TypeScript ([7c62d11](sidorares/node-mysql2@7c62d11)) ### [`v3.2.0`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​320-httpsgithubcomsidoraresnode-mysql2comparev312v320-2023-03-03) [Compare Source](sidorares/node-mysql2@v3.1.2...v3.2.0) ##### Features - maxVersion ssl option to tls.createSecureContext ([0c40ef9](sidorares/node-mysql2@0c40ef9)) ### [`v3.1.2`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​312-httpsgithubcomsidoraresnode-mysql2comparev311v312-2023-02-08) [Compare Source](sidorares/node-mysql2@v3.1.1...v3.1.2) ##### Bug Fixes - update `lru-cache` reset method to clear ([114f266](sidorares/node-mysql2@114f266)) ### [`v3.1.1`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​311-httpsgithubcomsidoraresnode-mysql2comparev310v311-2023-02-07) [Compare Source](sidorares/node-mysql2@v3.1.0...v3.1.1) ##### Bug Fixes - remove accidental log in caching_sha2\_password.js ([c1202b6](sidorares/node-mysql2@c1202b6)) ### [`v3.1.0`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​310-httpsgithubcomsidoraresnode-mysql2comparev301v310-2023-01-30) [Compare Source](sidorares/node-mysql2@v3.0.1...v3.1.0) ##### Features - cleanup buffer/string conversions in hashing/xor helpers that were failing in Bun ([a2392e2](sidorares/node-mysql2@a2392e2)) ##### Bug Fixes - when port is pased as a string convert it to a number (Bun's net.connect does not automatically convert this) ([703ecb2](sidorares/node-mysql2@703ecb2)) ### [`v3.0.1`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​301-httpsgithubcomsidoraresnode-mysql2comparev300v301-2023-01-13) [Compare Source](sidorares/node-mysql2@v3.0.0...v3.0.1) ##### Miscellaneous Chores - release 3.0.1 ([d5a6b2c](sidorares/node-mysql2@d5a6b2c)) ### [`v3.0.0`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#​300-httpsgithubcomsidoraresnode-mysql2comparev300-rc1v300-2023-01-12) [Compare Source](sidorares/node-mysql2@v2.3.3...v3.0.0) - named-placeholders library is updated to use newer `lru-cache` dependency, allowing it do dedupe and be shared between mysql2 and named-placeholders - sidorares/node-mysql2#1711, mysqljs/named-placeholders#19 - `chai` and `mocha` moved to devDependencies [#​1774](sidorares/node-mysql2#1774) - Amazon RDS ssl certificates updated including AWS China [#​1754](sidorares/node-mysql2#1754) - `TCP_NODELAY` flag enabled, avoiding long connect timeout in some scenarios [#​1751](sidorares/node-mysql2#1751) - typing improvements: [#​1675](sidorares/node-mysql2#1675), [#​1674](sidorares/node-mysql2#1674) - fix: ensure pooled connections get released [#​1666](sidorares/node-mysql2#1666) ##### Miscellaneous Chores - release 3.0.0 ([11692b2](sidorares/node-mysql2@11692b2)) ### [`v2.3.3`](sidorares/node-mysql2@v2.3.2...v2.3.3) [Compare Source](sidorares/node-mysql2@v2.3.2...v2.3.3) ### [`v2.3.2`](sidorares/node-mysql2@v2.3.1...v2.3.2) [Compare Source](sidorares/node-mysql2@v2.3.1...v2.3.2) ### [`v2.3.1`](sidorares/node-mysql2@v2.3.0...v2.3.1) [Compare Source](sidorares/node-mysql2@v2.3.0...v2.3.1) ### [`v2.3.0`](sidorares/node-mysql2@v2.2.5...v2.3.0) [Compare Source](sidorares/node-mysql2@v2.2.5...v2.3.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9--> Co-authored-by: Renovate Bot <renovate@vylpes.com> Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/128 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: RenovateBot <renovate@vylpes.com> Co-committed-by: RenovateBot <renovate@vylpes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of certificates in the documentation on aws.amazon.com is not comprehensive. It includes the Public and GovCloud certificates, but not the China certificates. As such, connections within AWS CN with the "ssl" key set to "Amazon RDS" fail with "unable to get local issuer certificate".
Compare:
I've tested this change by bundling my own branch of this module into an AWS Lambda deployment in China (via
esbuild) and successfully connecting to RDS in China using thessl: "Amazon RDS"flag.I've also
npm run lintandnpm run testwith no issues, thoughnpm run prettierwas a disaster, so I'll leave the formatting up to the maintainers 😄