Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): improve sanitization for big numbers support #2572

Merged
merged 1 commit into from Apr 9, 2024

Conversation

wellwelwel
Copy link
Collaborator

This PR continues the #2424 work, ensuring the type of parameters received in the connection and query options for both text and binary parsers.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.31%. Comparing base (8a818ce) to head (c6f329d).

Files Patch % Lines
lib/parsers/text_parser.js 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2572   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files          71       71           
  Lines       15700    15708    +8     
  Branches     1332     1332           
=======================================
+ Hits        14179    14187    +8     
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.31% <96.87%> (+<0.01%) ⬆️
compression-1 90.31% <96.87%> (+<0.01%) ⬆️
tls-0 89.83% <96.87%> (+<0.01%) ⬆️
tls-1 90.13% <96.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review April 9, 2024 01:20
@wellwelwel
Copy link
Collaborator Author

@sidorares, as these changes are simple, I'll merge it to release in #2566 (3.9.4) and follow the same way from #2529 (manually edit the Changelog.md to preserve the commit description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant