-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(security): improve results object creation #2574
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
=======================================
Coverage 90.31% 90.32%
=======================================
Files 71 71
Lines 15708 15717 +9
Branches 1333 1334 +1
=======================================
+ Hits 14187 14196 +9
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sidorares, as done in #2572, I'll merge and attribute the credits manually. Also, I've sent you some more detailed information by e-mail 🙋🏻♂️ |
Hi, Sorry for commenting on a closed PR, but it introduced a breaking changes for me. I created a reproduction repo https://github.com/ert78gb/mysql2-object-creation I would like to know what is your opinion about this "breaking changes". Do you think If you would like I could open a new issue. Thx, |
Hm... 🤔 Hi @ert78gb, I can't answer yet whether it's an unintentional breaking change for deep tests comparisons or if it can be fixed. I need to elaborate some tests. Thanks for the basic repro, I'll start with that. |
Finishing the tasks started in #2424 (and #2572).
This PR ensures a clean object evaluation for every item in results.
This is the final evaluation for both text and binary parsers:
Note
These changes preserve security without affecting the end user: