-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: binary parser sometimes reads out of packet bounds when results … #2601
fix: binary parser sometimes reads out of packet bounds when results … #2601
Conversation
thanks for fix PR and detailed report @Parsonswy ! Do you think it would be possible to include a unit test ( failing without The main change looks good to me |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2601 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 71 71
Lines 15725 15727 +2
Branches 1339 1339
=======================================
+ Hits 14204 14206 +2
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…contain null and typecast is false
d842c61
to
40f9224
Compare
@sidorares Certainly. Test added. |
LGTM 🚀 |
Fixes #2602.
Check the
nullBitmaskByte
before trying toreadLengthCodedBuffer()
whentypeCast: false
on binary results.