Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image zooming/viewing does not work properly on MacOS #6825

Open
2 tasks done
mlindner opened this issue Mar 12, 2024 · 10 comments
Open
2 tasks done

Image zooming/viewing does not work properly on MacOS #6825

mlindner opened this issue Mar 12, 2024 · 10 comments

Comments

@mlindner
Copy link

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

When clicking on an image to zoom it in, the size of the image preview is tiny within the overall window, and clicking to zoom in on the image does not view the image at full resolution. Additionally, the image should open in a pop out separate window.

Steps to reproduce

  1. Go to any chat with an image. 2. Click on it, observe small image. 3. Click again to attempt to zoom in, observe that the zoomed image isn't full resolution. 4. Additionally, stretch the window size and observe that somehow the full resolution zoomed image changes size as the window changes sizes

Expected result

Described in steps to reproduce.

Actual result

Described in steps to reproduce.

Screenshots

No response

Signal version

7.1.1

Operating system

Mac OS

Version of Signal on your phone

No response

Link to debug log

No response

@mlindner
Copy link
Author

MacOS version specifically is 12.7.3

@mlindner
Copy link
Author

Observe large black area around image after clicking on it, showing that clicking it doesn't do much:

image

Observe that even when zooming it only zooms partially and maintains a large black border:
image

Observe that changing the window size changes the zoomed resolution:
image

Full resolution image:
image

@ayumi-signal
Copy link
Contributor

Thanks for your feedback. This is not a bug, as it's by design. The screenshots suggest a window size which is very wide with low height, and we don't support this size well currently. This could be considered a UI enhancement type of issue. As for not popping out the image in a separate window, this is intentional.

For feature/design related enhancements, it is more helpful to share it in the forum where we will prioritize based on feedback.
https://community.signalusers.org/c/feature-requests/desktop-feature-requests/20

@mlindner
Copy link
Author

@ayumi-signal This behavior changed recently. It didn't used to work like this. This is a bug, not an enhancement, please re-open. Also the natural way to use signal is a wider than tall window, because of the contacts list on the left side.

@mlindner
Copy link
Author

Also you're missing the fact that image zoom does not work properly. It used to show the full image resolution, but no longer does that.

@ayumi-signal
Copy link
Contributor

If it's the case that this is a regression, then I apologize. Can you provide the app version # where zooming was working as expected?

@mlindner
Copy link
Author

I did some looking back at versions and the size of the black border size greatly expanded at least between 6.43.1 and 7.0.0. It's hard to test because of the database changes. The same image has a much larger black border after zooming in 7.0.0.

@mlindner
Copy link
Author

mlindner commented Mar 12, 2024

It seems 6.43.1 still has the zoom not being full resolution, but the problem seems to not be as bad as it is in 7.0.0 and later which is perhaps what caused me to notice it.

@ayumi-signal
Copy link
Contributor

Thank you for the additional information. We will take a look.

@mlindner
Copy link
Author

@ayumi-signal I'll add it has nothing to do with wide window aspect ratio. Making the window very thin and vertical shows the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants