Deep inspect attestations when filtering download #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarva
force-pushed
the
better-predicate-filter
branch
from
fc238bf
to
1aba417
Compare
Codecov Report
@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
- Coverage 30.45% 30.43% -0.02%
==========================================
Files 152 152
Lines 9586 9592 +6
==========================================
Hits 2919 2919
- Misses 6210 6216 +6
Partials 457 457
|
Fixes sigstore#3030 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
lcarva
force-pushed
the
better-predicate-filter
branch
from
1aba417
to
c8a030a
Compare
znewman01
approved these changes
Jun 2, 2023
|
Anything I can do to help this move along? 🙏 |
|
Thanks for the ping! I approved before the tests finished running and forgot to check back in o.O Sorry for the delay here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3030 by inspecting the attestation payload when filtering by predicate type. See additional context there.
Release Note
Documentation
Updated the command docs to no longer mention the predicate type is fetched from annotations.