Allow overriding remote options #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegistryOptions.GetRegistryClientOpts is used in a bunch of places, and it always instantiates a new set of options. This is ~fine for callers that only use the options once (e.g. the cosign CLI), but is unfortunate for callers that would like to reuse those options. It's useful to reuse these options because they represent a shared context that eliminates a lot of duplicate work across calls (e.g. authenticating with the registry and doing existence checks). Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #3049 +/- ##
==========================================
- Coverage 31.08% 31.06% -0.02%
==========================================
Files 155 155
Lines 9739 9744 +5
==========================================
Hits 3027 3027
- Misses 6250 6255 +5
Partials 462 462
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegistryOptions.GetRegistryClientOpts is used in a bunch of places, and it always instantiates a new set of options. This is ~fine for callers that only use the options once (e.g. the cosign CLI), but is unfortunate for callers that would like to reuse those options.
It's useful to reuse these options because they represent a shared context that eliminates a lot of duplicate work across calls (e.g. authenticating with the registry and doing existence checks).