Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use workers to limit the parallelism when verifying images #3069

Merged
merged 1 commit into from Jun 23, 2023
Merged

use workers to limit the parallelism when verifying images #3069

merged 1 commit into from Jun 23, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 21, 2023

Summary

  • use workers to limit the parallelism when verifying images

follow up of #3066

@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited

Codecov Report

Merging #3069 (c21a808) into main (ff648d5) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
- Coverage   30.72%   30.63%   -0.10%     
==========================================
  Files         155      155              
  Lines        9763     9793      +30     
==========================================
  Hits         3000     3000              
- Misses       6313     6343      +30     
  Partials      450      450
Impacted Files Coverage Δ
cmd/cosign/cli/dockerfile.go 0.00% <0.00%> (ø)
cmd/cosign/cli/manifest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify/verify.go 21.44% <0.00%> (-0.07%) ⬇️
cmd/cosign/cli/verify/verify_attestation.go 3.33% <0.00%> (-0.02%) ⬇️
internal/pkg/cosign/common.go 80.00% <ø> (ø)
pkg/cosign/verify.go 35.36% <0.00%> (-0.27%) ⬇️

@cpanato cpanato force-pushed the follow-up branch 2 times, most recently from 6710afe to 3afcb98 Compare June 21, 2023 08:03
hectorj2f
hectorj2f previously approved these changes Jun 21, 2023
View reviewed changes
hectorj2f
hectorj2f previously approved these changes Jun 21, 2023
View reviewed changes
@cpanato cpanato force-pushed the follow-up branch 6 times, most recently from 1395bf2 to 9ac4c1f Compare June 21, 2023 10:40
priyawadhwa
priyawadhwa reviewed Jun 21, 2023
View reviewed changes
pkg/cosign/verify.go Outdated Show resolved Hide resolved
@cpanato cpanato force-pushed the follow-up branch 6 times, most recently from 5520dde to 251b727 Compare June 21, 2023 14:12
@cpanato cpanato requested a review from priyawadhwa June 21, 2023 14:32
priyawadhwa
priyawadhwa reviewed Jun 21, 2023
View reviewed changes
pkg/cosign/verify.go Outdated Show resolved Hide resolved
haydentherapper
haydentherapper requested changes Jun 21, 2023
View reviewed changes
pkg/cosign/verify.go Outdated Show resolved Hide resolved
@cpanato cpanato force-pushed the follow-up branch 2 times, most recently from 47f67fc to ffcc94e Compare June 22, 2023 09:25
priyawadhwa
priyawadhwa reviewed Jun 22, 2023
View reviewed changes
pkg/cosign/verify.go Outdated Show resolved Hide resolved
@cpanato cpanato force-pushed the follow-up branch 2 times, most recently from 0d3d5ff to 29d90ee Compare June 22, 2023 10:14
priyawadhwa
priyawadhwa previously approved these changes Jun 22, 2023
View reviewed changes
@cpanato cpanato force-pushed the follow-up branch 2 times, most recently from 3792580 to 02cada8 Compare June 22, 2023 11:07
priyawadhwa
priyawadhwa previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!!

@cpanato
use workers to limit the paralellism when verifying images
c21a808 
Signed-off-by: cpanato <ctadeu@gmail.com>
@priyawadhwa priyawadhwa merged commit 84a5c8e into sigstore:main Jun 23, 2023
26 checks passed
@github-actions github-actions bot added this to the v2.1.0 milestone Jun 23, 2023
@cpanato cpanato deleted the follow-up branch June 23, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorj2f hectorj2f hectorj2f approved these changes

@haydentherapper haydentherapper haydentherapper approved these changes

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpanato @hectorj2f @haydentherapper @priyawadhwa