Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop namely/protoc-all in favour of a custom Dockerfile? #113

Open
kommendorkapten opened this issue Jul 28, 2023 · 3 comments
Open

Drop namely/protoc-all in favour of a custom Dockerfile? #113

kommendorkapten opened this issue Jul 28, 2023 · 3 comments

Comments

@kommendorkapten
Copy link
Member

When working on #112 I realised that the namely/protoc-all seems to be closed source, and it's very old (Debian Bullseye) which as an example lacks a new Go toolkit (only provides 1.15, released 2021).

It wasn't that hard to hack together a Docker image based on Alpine with rudimentary support for protoc. I think it would be worth exploring the work for adding Java, Ruby and other languages to make sure we know what's get into the image, and are not locked to a closed sourced vendor. As an example, I had to craft a new Docker image with newer Go version to be able to get the JSON schema generation to work.

cc @woodruffw @haydentherapper @znewman01

@woodruffw
Copy link
Member

+1 from me -- IMO having our own (non-closed) container would be a transparency and dependency quality win for us 🙂

@haydentherapper
Copy link
Collaborator

That’s good with me. We will use it in fulcio too, since we have to compile proto for grpc.

@jalseth
Copy link
Contributor

jalseth commented Aug 15, 2023

+1. We should consider using the buf CLI which is more ergonomic to use than upstream protoc CLi.

https://buf.build/docs/ecosystem/cli-overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants