Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the bundle format #116

Open
woodruffw opened this issue Jul 31, 2023 · 5 comments
Open

Stabilize the bundle format #116

woodruffw opened this issue Jul 31, 2023 · 5 comments

Comments

@woodruffw
Copy link
Member

Per sigstore/sig-clients#8: releasing a 1.0 version of the specs here would lend weight to cross-client standardization.

As part of that, we probably need a task burndown, along a few axes:

  1. What isn't in the specs yet that needs to be?
  2. What (breaking) changes to we want to make for a 1.0?
  3. What other language bindings do we want to be ready with a 1.0?
@woodruffw
Copy link
Member Author

woodruffw commented Jul 31, 2023

As a personal bugbear that I'd like to see addressed in 1.0: there are currently way too many valid states for the tuple of (inclusion promise, inclusion proof, checkpoint); I'd like it if we further ratcheted on the change in #82 and removed the inclusion promise entirely.

@haydentherapper
Copy link
Collaborator

We wouldn't be able to remove it entirely unfortunately, since it's still used as a signed timestamp from Rekor, but it could be moved under TimestampVerificationData. Verification then will require a promise+checkpoint, and a timestamp from either what's currently the "inclusion promise" or a TSA timestamp.

@haydentherapper
Copy link
Collaborator

Are we using https://github.com/sigstore/protobuf-specs/blob/main/protos/sigstore_verification.proto? One question is if we want a 1.0 release for everything or just the bundle format. I think the verification options are still a WIP. Do we have enough usage of trustroot for declaring it 1.0?

@kommendorkapten
Copy link
Member

For the trust root, I'd say we can declare it 1.0. We are using it for npm and some other projects.
For sigstore_verification we are using it to model a lot of the verification logic, including how complex policies can be broken down in to concrete verification steps, but i think its still to immature and not standardized over different clients yet to be 1.0, keeping that in alpha seems more sane to me.

@jku
Copy link
Member

jku commented Dec 20, 2023

For consideration WRT trustroot: #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants