Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions error running make locally #244

Open
haydentherapper opened this issue Mar 5, 2024 · 3 comments · May be fixed by #251
Open

Permissions error running make locally #244

haydentherapper opened this issue Mar 5, 2024 · 3 comments · May be fixed by #251

Comments

@haydentherapper
Copy link
Collaborator

There is a permissions error when trying to read the lock generated during rust codegen. This appears to surface after the rust codegen is complete and a later step accesses the lock (which appears to occur during json schema generation)

Building docker image for generating JSON schema files
docker build -t jsonschema-specs-build -f Dockerfile.jsonschema .
error checking context: no permission to read from '/usr/local/google/home/hayden/protobuf-specs/gen/pb-rust/target/debug/incremental/sigstore_protobuf_specs_codegen-233wpt7eagx8m/s-gu0xx5y87x-120l4cw.lock'
make: *** [Makefile:89: docker-image-jsonschema] Error 1

Running with sudo fixes this, but obviously is not ideal (and seems to create other errors for me, but that's probably due to my environment).

cc @woodruffw @tnytown

@haydentherapper
Copy link
Collaborator Author

Oh this might be more than just Rust, I see when I run make clean, I get permission denied errors for all generated files. I assume this is because the docker container generated the files? I guess we need to chown after generation?

@kommendorkapten
Copy link
Member

I think we should avoid running docker as root, let me see if I can take a quick look at this.

@kommendorkapten kommendorkapten linked a pull request Mar 7, 2024 that will close this issue
@kommendorkapten
Copy link
Member

@haydentherapper please take a look at #251 and see if it works better (you first need to clean up the existing files of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants