Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to install with uv #288

Open
jku opened this issue Apr 8, 2024 · 1 comment
Open

Fails to install with uv #288

jku opened this issue Apr 8, 2024 · 1 comment

Comments

@jku
Copy link
Member

jku commented Apr 8, 2024

https://github.com/astral-sh/uv currently fails to install protobuf-specs: theupdateframework/tuf-on-ci#205

  • uv does not accept pre-releases without an explicit --prerelease=allow
  • this project depends on betterproto 2.0.0b6

It's been about four years since 2.0.0b1 so waiting for betterproto to release might not be a good strategy. If we consider this important we could offer to do some work to the maintainer if that helps them make a release?

@woodruffw
Copy link
Member

It's been about four years since 2.0.0b1 so waiting for betterproto to release might not be a good strategy. If we consider this important we could offer to do some work to the maintainer if that helps them make a release?

Yeah, this would be ideal -- I've sent a few patches upstream to betterproto (in particular, fixing the handling of the Struct WKT), but I don't know how close they are to a stable 2.0 release.

(In particular, I still need to complete the fix in danielgtaylor/python-betterproto#559, which I'm still slightly murky on.)

More generally though, prereleases are part of PEP 440 and uv should support them, at least when fully pinned (e.g. protobuf-specs==2.0.0b6). So I think it might also be good to prod uv into finishing their prerelease support 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants