Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep http params sigstore java user-agent up to date. #100

Open
bobcallaway opened this issue Sep 2, 2022 · 4 comments
Open

keep http params sigstore java user-agent up to date. #100

bobcallaway opened this issue Sep 2, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@bobcallaway
Copy link
Member

Description

It would be good for clients to be able to specify a User-Agent header on HTTP requests to sigstore services.

@loosebazooka

@bobcallaway bobcallaway added the enhancement New feature or request label Sep 2, 2022
@loosebazooka
Copy link
Member

this is already possible using httpParams: https://github.com/sigstore/sigstore-java/blob/main/sigstore-java/src/main/java/dev/sigstore/http/HttpParams.java

However we don't inject the version into there which is probably something we should do. @vlsi any ideas for injecting compile time vars (rather than reading the jar manifest?)

@loosebazooka loosebazooka changed the title allow clients to set user-agent header keep http params sigstore java user-agent up to date. Jan 3, 2023
@vlsi
Copy link
Collaborator

vlsi commented Jan 3, 2023

WDYT of generating a class with the compile-time constants?

@vlsi
Copy link
Collaborator

vlsi commented Jan 3, 2023

@loosebazooka
Copy link
Member

Yeah, lets do that. Let me know if you want someone else to pick it up. I can also do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants